New outside numbers serializer - #207
Merged
Merged
Conversation
semiexp
reviewed
Mar 13, 2026
| let clues_up = surrounding[..width].to_vec(); | ||
| let clues_down = surrounding[width..(2 * width)].to_vec(); | ||
| let clues_left = surrounding[(2 * width)..(2 * width + height)].to_vec(); | ||
| let clues_right = surrounding[(2 * width + height)..].to_vec(); |
Owner
There was a problem hiding this comment.
I verified this order (up -> down -> left -> right) is consistent with that in Skyscrapers URLs
semiexp
approved these changes
Mar 13, 2026
semiexp
left a comment
semiexp
left a comment
Owner
There was a problem hiding this comment.
Thank you for a refactoring PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two new serializer, one for puzzle with two sets of external clues, and one with puzzle with four sets of external clues
Migrated affected puzzles to new serializer